Subject: Re: CVS commit: src/sys/dev/drm
To: Izumi Tsutsui <tsutsui@ceres.dti.ne.jp>
From: Michael Lorenz <macallan@netbsd.org>
List: source-changes
Date: 03/21/2007 02:12:20
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hello,

On Mar 20, 2007, at 22:26, Izumi Tsutsui wrote:

> macallan@NetBSD.org wrote:
>
>> Module Name:	src
>> Committed By:	macallan
>> Date:		Wed Mar 21 02:11:45 UTC 2007
>>
>> Modified Files:
>> 	src/sys/dev/drm: drm_vm.c
>>
>> Log Message:
>> we return addresses, not page numbers in *mmap() methods
>
> Doesn't it archtecture dependent?
> (Umm, there are also many vtophys() in it)

Yes, sort of. In doubt it's what bus_space_mmap() returns ( and the man 
page says 'physical address or opaque token' ). If at all then vtophys 
should do The Right Thing and we shouldn't have to atop() anything.

have fun
Michael
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (Darwin)

iQEVAwUBRgDMxMpnzkX8Yg2nAQIo9Af/Rwm66KXA5jODPHkRAUhggWY2KqDY+B+H
53fBQmr6e+2hsd/Wqxch019hcrggZtJtXSMTlPqY5Y87QB3sQFaoOC5mpH/8Ams7
+qtOLHf+p2PkcBI5KNvYJgUAJ+BrKMK1fnUJ2AfEbEVnyOq4MWOk3bGkbl6pDB3z
Ce/xQ0l7VkO6urx0WIi7UlnK0LeYMAWDBZtEF8FT4eh+pmC+hWpPLWdYx4NOZplM
RHKGgL76kNP/zb+zUl7IumXM02t5Y4R2i4aayivBJabdW1KdDfIw4aTvHeIxD7H2
bn/LU9M7nhxEJ3gsJoQSpoaJj9Ftgou93fN5AjuT51Ec1co19dhfkg==
=swTo
-----END PGP SIGNATURE-----