Re: CVS commit: src/sys/arch/evbppc

[David Young <dyoung%pobox.com@localhost>]

On Mon, Feb 26, 2007 at 01:24:19PM +0100, Jachym Holecek wrote:
> # Jason R Thorpe 2007-02-22:
> > Module Name:        src
> > Committed By:       thorpej
> > Date:               Thu Feb 22 05:27:47 UTC 2007
> > 
> > Modified Files:
> >     src/sys/arch/evbppc/ev64260: gt_mainbus.c
> >     src/sys/arch/evbppc/explora: machdep.c
> >     src/sys/arch/evbppc/obs405/dev: century_bios.c
> >     src/sys/arch/evbppc/virtex: design_gsrd2.c machdep.c
> >     src/sys/arch/evbppc/walnut: autoconf.c machdep.c
> > 
> > Log Message:
> > TRUE -> true, FALSE -> false
> 
> BTW I think the proplib convention of returning true on success and
> false on failure should change to the usual "zero on success, nonzero
> on failure" (and preferrably errno value, rather than just "false").
> All proplib callers I've seen do something like
> 
>   if (prop_foo(...) == false ||
>       prop_bar(...) == false)
>         ... deal with failure ...
> 
> anyway, so we can save ourselves the " == false" part plus be more
> consistent with the rest of the source.

Can we also save ourselves the '== false' part using '!', or am I
missing something?

Dave

-- 
David Young             OJC Technologies
dyoung%ojctech.com@localhost      Urbana, IL * (217) 278-3933