Subject: Re: CVS commit: src/bin/sh
To: Lubomir Sedlacik <salo@Xtrmntr.org>
From: Roland Illig <rillig@NetBSD.org>
List: source-changes
Date: 02/15/2007 16:11:27
> On Thu, Feb 15, 2007 at 12:02:59PM +0000, Roland Illig wrote:
>
>>Module Name: src
>>Committed By: rillig
>>Date: Thu Feb 15 12:02:59 UTC 2007
>>
>>Modified Files:
>> src/bin/sh: input.c
>>
>>Log Message:
>>Since interpreting ELF binaries as shell scripts is not very useful, and
>>since the current error message is less than helpful, improve it.
Lubomir Sedlacik wrote:
> are you going to add checks for all the millions of other binary (and
> text) formats, too? why should be ELF binaries treated any differently?
Manuel Bouyer wrote:
> Why only ELF binaries ? The issue is the same for other types of
> binaries too (a.out, ecoff, etc ...)
Answer for both: Because I think they are the most common case nowadays.
If you don't like it, feel free to replace this code with a simple
binary file check. But don't forget to keep the filename in the error
message. That's the main improvement of my change.
And no, I didn't intend to add more checks like this. It was just that
the previous error message was so misleading and bad ...
Roland