Subject: CVS commit: src/usr.bin/mail
To: None <source-changes@NetBSD.org>
From: Christos Zoulas <christos@netbsd.org>
List: source-changes
Date: 01/03/2007 00:24:36
Module Name:	src
Committed By:	christos
Date:		Wed Jan  3 00:24:36 UTC 2007

Modified Files:
	src/usr.bin/mail: mime_attach.c mime_decode.c

Log Message:
1) Fix a really stupid table termination error in mime_decode.c.

2) When doing attachments set the "name=" parameter of the
Content-Type field, in addition to the (already) set "filename="
parameter of the Content-Disposition field.  Some utilities (e.g.,
metamail) use this parameter for the filename even though (I believe)
the "filename=" parameter of the Content-Disposition field is
preferred by the standard (I can't find this explicitly except for
"application/octet-stream" types - see RFC1521 sec 7.4.1 and RFC2046
sec 4.5.1).  My impression is that the "name=" parameter of the
Content-Types field is really intended for use when retrieving a file
not in the message, e.g., "message/external-body" Content-Types, and
not for the filename.
(Thanks to wiz@ for noticing this in his spam logs.)

3) Be more careful when determining the Content-Type of 1-byte
attachments.  libmagic(3) isn't helpful on such small files.


To generate a diff of this commit:
cvs rdiff -r1.3 -r1.4 src/usr.bin/mail/mime_attach.c
cvs rdiff -r1.7 -r1.8 src/usr.bin/mail/mime_decode.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.