Subject: Re: CVS commit: src/sys/dev/sysmon
To: matthew green <mrg@eterna.com.au>
From: Steven M. Bellovin <smb@cs.columbia.edu>
List: source-changes
Date: 12/20/2006 10:30:42
On Wed, 20 Dec 2006 16:55:35 +1100
matthew green <mrg@eterna.com.au> wrote:
>
>
> Module Name: src
> Committed By: smb
> Date: Tue Dec 19 21:17:17 UTC 2006
>
> Modified Files:
> src/sys/dev/sysmon: swwdog.c
>
> Log Message:
> Handle new gcc properly
>
>
> hmm... shouldn't this not be necessary? sys/conf/Makefile.kern.inc
> has:
>
> CWARNFLAGS+= -Wextra -Wno-unused-parameter
>
> which means it should be OK without this change.
>
Not sure. I know I had to make the change a while ago; yesterday, I
noticed that I'd never committed it, so I did. Given that I already
did it, let's leave it -- I can make a good case that it's better to
have the 'unused' notice locally rather than globally, if you possibly
can.
--Steve Bellovin, http://www.cs.columbia.edu/~smb