Re: CVS commit: src/sys/dev/scsipi

[Christian Biere <christianbiere%gmx.de@localhost>]

Manuel Bouyer wrote:
> > > Add __aligned__(4) to all the structures.
> > 
> > Uh oh... I wonder if maybe putting it on all the structures wasn't such
> > a good idea after all... while the ATA/ATAPI devices seem OK, SCSI seems
> > broken now:

> I've not looked closely at the commit but I suspect some structs here are
> really used unaligned, packed with some other, or a single int8.

I suggest using STATIC_ASSERT(sizeof(struct whatever) == whatever) wherever
size matters.

-- 
Christian