Source-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/common/lib/libprop



In article <20061019154621.GA3736@cyclonus>,
Christian Biere  <christianbiere%gmx.de@localhost> wrote:
>Jason Thorpe wrote:
>> >Log Message:
>> >sysconf() returns long, which isn't neccessarily assignment-compatible
>> >with size_t, as evidenced by sh5, so add an explicit cast.
>> 
>> The sh5 port is wrong.  It should be unsigned long in both the LP64  
>> and the ILP32 case.  E.g. sparc/sparc64 does this.
>
>And i386 should have "size_t == unsigned long" as well. It also helps a lot
>to prevent format string bugs as I pointed out in PR lib/34516.

This is going to cause a flag day for c++, which is the reason it has not
been changed.

christos




Home | Main Index | Thread Index | Old Index