Subject: Re: CVS commit: src/common/lib/libprop
To: Jason Thorpe <thorpej@shagadelic.org>
From: David Laight <david@l8s.co.uk>
List: source-changes
Date: 10/16/2006 20:29:16
On Mon, Oct 16, 2006 at 11:03:27AM -0700, Jason Thorpe wrote:
>
> On Oct 16, 2006, at 9:14 AM, Tom Spindler wrote:
>
> >There's also other warnings/build breakages generated on x86_64 in
> >lib/libprop
> >with _PROP_CALLOC in userland, "fixed" by changing
> >
> >-#define _PROP_CALLOC(s, t) calloc(1, (s))
> >+#define _PROP_CALLOC(s, t) calloc((size_t) 1, (s))
> >
> >in prop_object_impl.h - but I'll let you fix it as you deem
> >appropriate.
>
> This is a completely bogus fix. IMO, lint(1) is out of line warning
> about a constant argument that falls within the valid range of the
> data type of that argument.
Agreed - I personally have a strong dislike for casts used to change
the type of integer expressions.
David
--
David Laight: david@l8s.co.uk