Subject: Re: CVS commit: src/common/lib/libprop
To: Jason R Thorpe <thorpej@netbsd.org>
From: Tom Spindler <dogcow@babymeat.com>
List: source-changes
Date: 10/16/2006 09:14:55
the x86_64 build now breaks during the lint stage:

CC=/home/dogcow/work/nbobj/tools/bin/x86_64--netbsd-gcc /home/dogcow/work/nbobj/tools/bin/x86_64--netbsd-lint -chapbxzFS -w -d /home/dogcow/work/nbobj/a64dd/usr/include  -D_LIBPROP -D_REENTRANT -I/home/dogcow/work/nbsrc/lib/libc/include    -i /home/dogcow/work/nbsrc/common/lib/libprop/prop_data.c
/home/dogcow/work/nbsrc/common/lib/libprop/prop_data.c(417): warning: conversion from 'long' to 'unsigned char' may lose accuracy [132]
/home/dogcow/work/nbsrc/common/lib/libprop/prop_data.c(429): warning: conversion from 'long' to 'unsigned char' may lose accuracy [132]
/home/dogcow/work/nbsrc/common/lib/libprop/prop_data.c(442): warning: conversion from 'long' to 'unsigned char' may lose accuracy [132]
/home/dogcow/work/nbsrc/common/lib/libprop/prop_data.c(452): warning: conversion from 'long' to 'unsigned char' may lose accuracy [132]
[...]
nbmake: stopped in /home/dogcow/work/nbsrc/lib/libprop

There's also other warnings/build breakages generated on x86_64 in lib/libprop
with _PROP_CALLOC in userland, "fixed" by changing

-#define        _PROP_CALLOC(s, t)      calloc(1, (s))
+#define        _PROP_CALLOC(s, t)      calloc((size_t) 1, (s))

in prop_object_impl.h - but I'll let you fix it as you deem appropriate.