Subject: Re: CVS commit: src/sys/arch/sh3/sh3
To: Quentin Garnier <cube@cubidou.net>
From: Simon Burge <simonb@NetBSD.org>
List: source-changes
Date: 10/12/2006 08:25:41
Quentin Garnier wrote:
> On Wed, Oct 11, 2006 at 10:11:13PM +0900, Izumi Tsutsui wrote:
> > uwe@NetBSD.org wrote:
> >
> > > Modified Files:
> > > src/sys/arch/sh3/sh3: cpu.c
> > >
> > > Log Message:
> > > Lift extern cpu_cd declaration to the top-level.
> >
> > It's better to include "ioconf.h" for struct cfdriver foo_cd decls.
>
> Well, it depends. Including ioconf.h means the file will be compiled
> much more often than necessary.
OTOH, it's another extern that needs to be tracked down of we ever
change those decls in any way. The more externs we can remove the
better (in my opinion).
Simon.