Subject: re: CVS commit: src/share/mk
To: Elad Efrat <elad@NetBSD.org>
From: matthew green <mrg@eterna.com.au>
List: source-changes
Date: 10/09/2006 08:37:23
matthew green wrote:
>
> Module Name: src
> Committed By: elad
> Date: Sun Oct 8 17:16:51 UTC 2006
>
> Modified Files:
> src/share/mk: bsd.README bsd.sys.mk
>
> Log Message:
> PR/28368: Peter Postma: unrecognized option `-Wnetbsd-format-audit'
>
> Apply patch from rivo nurges in #NetBSD-code, thanks!
>
>
> hmmm, i'm not sure this is the right solution. i think we want to
> re-port this code to newer GCC rather than abandon it entirely.
>
> please back this out, re-open the PR and assign it to me.
This was discussed as not being useful anymore and okay'd by several
developers. I don't mind re-opening it and assigning to you, but out of
curiosity I must ask: what are you going to "audit" with this thing?
the netbsd source tree. this option increase the scope of what
GCC checks for printf-like format strings. it was added to netbsd
gcc by sommerfeld to address cases where the format string is not
literally part of the function call, eg:
const char foo[]="%s %d";
printf(foo, 1, "2");
see, eg, src/gnu/dist/gcc/c-common.c revs 1.9 & 1.10 (note this
file is in the Attic...)
hmm, it occurs to me that this may be what GCC does now anyway.
in any case, please re-open and assign to me, and i will deal
with it.
thanks.
.mrg.