Re: CVS commit: src/sys/dev/scsipi

["Charles M. Hannum" <mycroft%MIT.EDU@localhost>]

On Mon, Sep 11, 2006 at 05:57:07PM +0000, Reinoud Zandijk wrote:
> 
> Module Name:  src
> Committed By: reinoud
> Date:         Mon Sep 11 17:57:07 UTC 2006
> 
> Modified Files:
>       src/sys/dev/scsipi: scsipi_base.c
> 
> Log Message:
> Don't add one to the capacity returned of READ CAPACITY! it results in
> reporting a sd* disc that is one sector too big (!) Normally not much a
> problem in FFS since its clustered but other filingsystems *do* care.

*facepalm*

Could you please READ THE SPEC before committing??  READ CAPACITY is
supposed to return the highest LBA; to get the number of blocks, you
have to add one.

I realize that some broken USB devices return the wrong number, but
that's no excuse for breaking the interface for everyone else.