Subject: Re: CVS commit: src
To: None <blymn@netbsd.org>
From: YAMAMOTO Takashi <yamt@mwd.biglobe.ne.jp>
List: source-changes
Date: 09/06/2006 23:35:50
> Module Name:	src
> Committed By:	blymn
> Date:		Wed Sep  6 13:37:49 UTC 2006
> 
> Modified Files:
> 	src/share/man/man9: fileassoc.9
> 	src/sys/kern: kern_fileassoc.c
> 	src/sys/sys: fileassoc.h
> 
> Log Message:
> * Remove "hinted" interface
> * Modify fileassoc internals to use fhandle_t instead of fileid
> 
> 
> To generate a diff of this commit:
> cvs rdiff -r1.8 -r1.9 src/share/man/man9/fileassoc.9
> cvs rdiff -r1.8 -r1.9 src/sys/kern/kern_fileassoc.c
> cvs rdiff -r1.4 -r1.5 src/sys/sys/fileassoc.h
> 
> Please note that diffs are not public domain; they are subject to the
> copyright notices on the relevant files.

- please use vfs_composefh_free rather than kmem_free.
- comparing FHANDLE_SIZE is not the same as comparing fid_len
  because FHANDLE_SIZE is padded.
- you seem leaking "th" in some cases.
- tab vs space problems?

YAMAMOTO Takashi