Subject: CVS commit: src/sys/arch/sh3/sh3
To: None <source-changes@NetBSD.org>
From: Valeriy E. Ushakov <uwe@netbsd.org>
List: source-changes
Date: 09/06/2006 00:11:49
Module Name:	src
Committed By:	uwe
Date:		Wed Sep  6 00:11:49 UTC 2006

Modified Files:
	src/sys/arch/sh3/sh3: db_interface.c

Log Message:
__db_print_symbol: don't try to be too smart with db_print_loc_and_inst.

We can have in a register an address that points to/into some variable
in the data segment, but db_print_loc_and_inst only looks for
functions, so it will misprint it as something unrelated from libkern
+ huge offset.  E.g. instead of netbsd:cpu_info_store it would print
netbsd:prop_string_create_cstring+0xdeadbeef

Worse, if the address happens to be odd (char field in a struct, an
element of char array), attempt at printing the "instruction" at that
address will cause a fault and will abort "mach frame".

Disassemly is not really that useful in "mach frame" listing anyway
and more often just clutters things by overflowing 80 columns.


To generate a diff of this commit:
cvs rdiff -r1.36 -r1.37 src/sys/arch/sh3/sh3/db_interface.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.