Subject: Re: CVS commit: src/sys
To: Jason Thorpe <thorpej@shagadelic.org>
From: Garrett D'Amore <garrett_damore@tadpole.com>
List: source-changes
Date: 09/02/2006 17:16:28
Jason Thorpe wrote:
>
> On Sep 2, 2006, at 1:18 PM, Garrett D'Amore wrote:
>
>>
>> Module Name:    src
>> Committed By:    gdamore
>> Date:        Sat Sep  2 20:18:00 UTC 2006
>>
>> Modified Files:
>>     src/sys/conf: files
>> Added Files:
>>     src/sys/kern: kern_todr.c
>>
>> Log Message:
>> Add MI implementation of inittodr, todr_attach, and resettodr.
>>
>> This is triggered upon __HAVE_GENRIC_TODR in machine/types.h. 
>> Conversion of
>> evbmips port forthcoming.
>
> Wouldn't this be better placed in sys/dev/todr.c, and use a config
> attribute to bring it in (or let MD files.* files specify its use)?

I don't think so.  Its not a todr itself, but rather the framework by
which a todr interacts with the rest of the kernel.  Normally this code
is found in some machdep kernel code next to where the clock setup is
done, and not part of the dev/ tree for the port.

    -- Garrett

-- 
Garrett D'Amore, Principal Software Engineer
Tadpole Computer / Computing Technologies Division,
General Dynamics C4 Systems
http://www.tadpolecomputer.com/
Phone: 951 325-2134  Fax: 951 325-2191