Re: CVS commit: src/etc/rc.d

[David Young <dyoung%pobox.com@localhost>]

On Mon, Aug 07, 2006 at 09:37:23AM +1000, Luke Mewburn wrote:
> On Sat, Aug 05, 2006 at 05:26:15PM +0000, David Young wrote:
>   | 
>   | Module Name:      src
>   | Committed By:     dyoung
>   | Date:             Sat Aug  5 17:26:15 UTC 2006
>   | 
>   | Modified Files:
>   |   src/etc/rc.d: Makefile
>   | 
>   | Log Message:
>   | Only install ipfilter, ipfs, ipmon, and ipnat if MKIPFILTER=no.
>   | 
>   | To generate a diff of this commit:
>   | cvs rdiff -r1.58 -r1.59 src/etc/rc.d/Makefile
> 
> 
> This is not consistent with other optional components
> such as pf, X11 (etc).
> Please revert.

No problem, but please understand how we got here: my patch fixes the
"bug" introduced by jwise@ with rev 1.163 of distrib/sets/lists/etc/mi:
'build.sh -V MKIPFILTER=no distribution' failed in the checkflist step.
Jim did not change the Makefile, so I am not sure how a build passed
his tests.

I see, now, that my sources are a bit behind the MKIPFILTER=no saga:
peter@ removed the ipfilter flags in rev 1.173.  The commit message,
"Fix MKIPFILTER=no.", does not reference rev 1.163.  Jim went to some
trouble to describe his change in his commit message.  Was the reversal
discussed somewhere?

> If there's a concern about installing rc.d scripts for
> disabled optional components, start a discussion on
> tech-userlevel.

No thank you.  Maybe Jim cares enough to argue the point.  I just want
my builds to work.

Dave

-- 
David Young             OJC Technologies
dyoung%ojctech.com@localhost      Urbana, IL * (217) 278-3933