Re: CVS commit: src/gnu/dist/gcc4/libobjc

[Jason Thorpe <thorpej%shagadelic.org@localhost>]

On May 13, 2006, at 7:14 PM, Christos Zoulas wrote:

> Module Name:    src
> Committed By:   christos
> Date:           Sun May 14 02:14:33 UTC 2006
>
> Modified Files:
>         src/gnu/dist/gcc4/libobjc: Object.m
>
> Log Message:
> Casts to appease gcc.

It would be more appropriate to cast to (id) rather than (void *).

Index: Object.m
===================================================================
RCS file: /cvsroot/src/gnu/dist/gcc4/libobjc/Object.m,v
retrieving revision 1.1.1.1
retrieving revision 1.2
diff -u -p -r1.1.1.1 -r1.2
--- Object.m    20 Apr 2006 09:55:15 -0000      1.1.1.1
+++ Object.m    14 May 2006 02:14:33 -0000      1.2
@@ -121,7 +121,7 @@ extern int errno;
     return 0;
   // Ordering objects by their address is pretty useless,
   // so subclasses should override this is some useful way.
-  else if (self > anotherObject)
+  else if ((void *)self > (void *)anotherObject)
     return 1;
   else
     return -1;

-- thorpej