On Fri, Apr 14, 2006 at 01:09:07PM +0000, Brett Lymn wrote: > > Module Name: src > Committed By: blymn > Date: Fri Apr 14 13:09:07 UTC 2006 > > Modified Files: > src/sys/arch/acorn32/mainbus: fd.c > src/sys/arch/arc/jazz: fd.c > src/sys/arch/atari/dev: hdfd.c > src/sys/arch/hp300/dev: rd.c > src/sys/arch/pdp10/dev: hp.c > src/sys/arch/sparc/dev: fd.c tctrl.c > src/sys/arch/vax/mba: hp.c > src/sys/arch/x68k/dev: fd.c > src/sys/conf: files > src/sys/dev/gpib: rd.c > src/sys/dev/isa: fd.c > src/sys/dev/scsipi: st.c stvar.h > src/sys/kern: init_sysctl.c subr_disk.c > src/sys/nfs: nfs_vfsops.c nfs_vnops.c nfsmount.h > src/sys/sys: Makefile disk.h sysctl.h > Added Files: > src/sys/sys: iostat.h > > Log Message: > Make i/o statistics collection more generic, include tape drives and > nfs mounts in the set of devices that statistics will be reported on. I'm probably as guilty as you are for getting on you about this so late after the commit, but replacing the MIB number by something incompatible was a very, very poor decision. I can understand that you'd want to remove support for the old HW_DISKSTATS API, but that's not a reason to close the door to any mean of providing binary compatibility for older binaries. Breaking API (such that unconverted programs break during compilation) is one understandable thing, but breaking ABI is Not Nice(TM). This is even more unfortunate that nowadays MIB numbers really don't matter, the fixed ones are remanents of an older time, and they're there for the *sole* reason of providing binary compatibility. So please, please, have a MIB number dynamically allocated for iostats, and leave HW_DISKSTATS as it was, so that maybe someone could provide the necessary COMPAT_30 stub to support older binaries. I haven't looked at the details of the involved struct, but it'd better be COMPAT_NETBSD32-friendly or I'll be really angry :-) I'm kind of sorry I couldn't check that earlier. -- Quentin Garnier - cube%cubidou.net@localhost - cube%NetBSD.org@localhost "When I find the controls, I'll go where I like, I'll know where I want to be, but maybe for now I'll stay right here on a silent sea." KT Tunstall, Silent Sea, Eye to the Telescope, 2004.
Attachment:
pgpM9cJcz7yek.pgp
Description: PGP signature