On Apr 20, 10:50am, thorpej@shagadelic.org (Jason Thorpe) wrote:
-- Subject: Re: CVS commit: [elad-kernelauth] src/sys/ufs/ext2fs

| 
| On Apr 20, 2006, at 9:40 AM, Christos Zoulas wrote:
| 
| > You cannot do that in some cases (the fsck sources for example, I  
| > showed
| > in the previous message).
| 
| I just don't buy this argument at all.  WTF is userland code doing  
| #including ext2fs_extern.h??  That should be a kernel-only header.

Userland code is using ext2fs_bswap.c which is a kernel file. A kernel
file is including the kernel header. The other fsck's do this too.
Really, it is good enough to use "struct kauth_cred *". This is why
we don't have a lot of typedefs in the kernel: so that we don't have
to include the world to make things compile. Your example of vaddr_t
just proves my point. Can we please reach consensus on this so I can
commit the changes and so we can move on? You still have not replied
on the practical advantage of using a typedef vs. using a struct pointer...

christos