Re: CVS commit: src/sys/lib/libsa

[christos%astron.com@localhost (Christos Zoulas)]

In article <20060403140841.6B9802DA27%cvs.netbsd.org@localhost>,
Cherry G. Mathew <cherry%netbsd.org@localhost> wrote:
>
>Module Name:   src
>Committed By:  cherry
>Date:          Mon Apr  3 14:08:41 UTC 2006
>
>Modified Files:
>       src/sys/lib/libsa: loadfile_elf32.c
>
>Log Message:
>Allows processor ABI specific ELF segment loads.
>If the macro MD_LOADSEG defined in
>machine/loadfile_machdep.h evaluates to 1, the machine
>specific segment is loaded.

Why didn't you encapsulate the test for (phdr[i].p_type & PT_LOPROC)
in MD_LOADSEG(phdr[i]) as I suggested? PT_LOPROC throup PT_HIPROC are
reserved for processor-specific extensions. Thus another architecture
might choose not to set PT_LOPROC, but set PT_LOPROC + 1 to indicate
that it wants to load a segment. Clearly the test does not belong in
MI code, since the test has processor-specific semantics.

christos