Subject: Re: CVS commit: src/sys/ufs/ffs
To: Pavel Cahyna <pavel.cahyna@st.mff.cuni.cz>
From: Hubert Feyrer <hubert@feyrer.de>
List: source-changes
Date: 03/23/2006 14:43:55
On Thu, 23 Mar 2006, Pavel Cahyna wrote:
>> Modified Files:
>> 	src/sys/ufs/ffs: ffs_balloc.c
>>
>> Log Message:
>> ffs_balloc*(): Add an assertion for "bpp != NULL" if B_METAONLY is set.
>
> Why? bpp is immediately dereferenced, so if it is NULL, the kernel will
> panic anyway.

I guess the error message from assert is somewhat more useful than from a 
panic due to jumping though a NULL pointer.

(didn't we have that a few weeks ago?)


  - Hubert