Subject: Re: CVS commit: [elad-kernelauth] src/sys
To: None <elad@NetBSD.org>
From: YAMAMOTO Takashi <yamt@mwd.biglobe.ne.jp>
List: source-changes
Date: 03/09/2006 11:39:36
> > its name doesn't imply anything about its usage.
> > generally, exporting more symbols is a bad idea, esp. when
> > its name is too generic like this.
> > 
> > i think it's better to make it static and
> > move process_authorize to kern_auth.c.
> 
> See attached diff, it:
> 
>   - changes builtin_{generic,process} to
>     kauth_builtin_scope_{generic,process}, and makes them static.
>   - remove extern for the above two from kauth.h.
>   - moves process_authorize() from kern_proc.c to kern_auth.c.
> 
> Is this okay?
> 
> -e.

looks fine to me.

YAMAMOTO Takashi