Subject: Re: CVS commit: [elad-kernelauth] src/sys
To: None <elad@netbsd.org>
From: YAMAMOTO Takashi <yamt@mwd.biglobe.ne.jp>
List: source-changes
Date: 03/08/2006 14:17:32
> Module Name: src
> Committed By: elad
> Date: Tue Mar 7 23:23:56 UTC 2006
>
> Added Files:
> src/sys/kern [elad-kernelauth]: kern_auth.c
> src/sys/sys [elad-kernelauth]: kauth.h
>
> Log Message:
> Add kernel authorization routines.
- IMO, it's better to use "org.netbsd.kauth.generic" as TN says.
- how about providing suser() as a wrapper of KAUTH_GENERIC_ISSUSER? (for now?)
- builtin_process seems like a too generic name to me.
- will you convert CURTAIN to KAUTH_PROCESS_CANSEE?
- locking seems broken. try LOCKDEBUG.
- consider to follow our style.
- you can use SIMPLEQ_INSERT_TAIL on an empty queue.
YAMAMOTO Takashi