Source-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/arch/amd64/include



On Tue, Mar 07, 2006 at 07:34:57AM +1100, Simon Burge wrote:
> Quentin Garnier wrote:
> 
> > Module Name:        src
> > Committed By:       cube
> > Date:               Mon Mar  6 08:30:44 UTC 2006
> > 
> > Modified Files:
> > 
> >     src/sys/arch/amd64/include: cpu.h
> > 
> > Log Message:
> > 
> > delay() is gone, so don't declare it.  That way other parts of code that
> > use a variable named delay (say, netinet6/in6.c) won't shadow something
> > that doesn't exist anyway.
> 
> delay() is used in many parts of MI code.  Given delay(9), shouldn't
> local variables named "delay" be renamed instead?

Sure, that doesn't mean we can't clean up.  There's no actual function
named delay() in amd64, it's just a left over of some old i386 code.

It was the easy way out for me, I agree :)

-- 
Quentin Garnier - cube%cubidou.net@localhost - cube%NetBSD.org@localhost
"When I find the controls, I'll go where I like, I'll know where I want
to be, but maybe for now I'll stay right here on a silent sea."
KT Tunstall, Silent Sea, Eye to the Telescope, 2004.

Attachment: pgpoD8Gyk4_QN.pgp
Description: PGP signature



Home | Main Index | Thread Index | Old Index