Re: CVS commit: src/sys/arch/evbmips

[Jason Thorpe <thorpej%shagadelic.org@localhost>]

On Feb 23, 2006, at 10:10 AM, Izumi Tsutsui wrote:

> In article <20060223171401.27E742DA27%cvs.netbsd.org@localhost>
> shige%NetBSD.org@localhost wrote:
>
> > Module Name:    src
> > Committed By:   shige
> > Date:           Thu Feb 23 17:14:01 UTC 2006
> >
> > Modified Files:
> >         src/sys/arch/evbmips/conf: files.alchemy
> > Added Files:
> >         src/sys/arch/evbmips/alchemy: omsal400.c omsal400reg.h
> >         src/sys/arch/evbmips/conf: OMSAL400
> >
> > Log Message:
> > Support Plathome OpenMicroServer (OMS-AL400).
> > http://www.plathome.co.jp/products/oms400/index.html (sorry  
> > japanese only).
>
> Isn't it better to create new directory for the machine
> (evbmips/oms400 etc)? I guess evbmips/alchemy is a directory
> for the AMD's Development Boards for Au1xxx CPUs.

I agree is probably better to have boards (especially boards from  
different vendors) in different directories.  evbarm does it this  
way, for example.  I think the small amount of duplicated code winds  
up being outweighed by the more natural organization.

> Anyway, please have a review before commit as noted in
> the commit guidelines. Thanks.
> ---
> Izumi Tsutsui

-- thorpej