Subject: Re: CVS commit: src/sys/dev/pci
To: Tim Rightnour <root@garbled.net>
From: Garrett D'Amore <garrett_damore@tadpole.com>
List: source-changes
Date: 02/23/2006 14:38:25
Tim Rightnour wrote:
> On 23-Feb-2006 Jared D. McNeill wrote:
>
>> This might not be a big deal, but I'd just like to point out that in
>> the event that someone boots a kernel that includes the autri driver
>> but not the pcn driver, with this solution the autri driver will
>> still try to attach.
>>
>
> The code I originally committed prevents that. I could do as suggested by
> Jason and make the autri match on it's class, and none other. That might make
> more sense, but requires knowledge of what that class is, and some assurances
> that thats the only class the real autri shows up as.
>
> ---
> Tim Rightnour <root@garbled.net>
> NetBSD: Free multi-architecture OS http://www.netbsd.org/
> Genecys: Open Source 3D MMORPG: http://www.genecys.org/
>
I would vote that you do this. if autri shows up as something else,
then someone will complain and we can re-evaluate at that point. The
likelihood is that they will always have a reasonable class.
Generally, most chip mfgs preprogram the class and OEM vendors almost
never change it. (In many designs, they "can't" -- its hardwired.)
--
Garrett D'Amore, Principal Software Engineer
Tadpole Computer / Computing Technologies Division,
General Dynamics C4 Systems
http://www.tadpolecomputer.com/
Phone: 951 325-2134 Fax: 951 325-2191