Subject: CVS commit: src/sys/coda
To: None <source-changes@NetBSD.org>
From: Greg Troxel <gdt@netbsd.org>
List: source-changes
Date: 01/12/2006 14:57:06
Module Name:	src
Committed By:	gdt
Date:		Thu Jan 12 14:57:06 UTC 2006

Modified Files:
	src/sys/coda: coda_vnops.c

Log Message:
In coda_lookup, add LK_RETRY to locking of child vnode.  The previous
code paniced if the first attempt to lock the vnode failed, and such
failures are not errors - just cause to wait.  gdt was regularly
hitting this panic.

Correct one of two identical panic messages.

Add XXX comments about

  ISDOTDOT locking rules not being followed

  questioning the practice of unlocking parent before locking child.
  (But, given that the vnode is referenced, it can't be deleted, so
  maybe this is fine.)

  Why is failured to unlock not a panic but failure to lock is?


To generate a diff of this commit:
cvs rdiff -r1.45 -r1.46 src/sys/coda/coda_vnops.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.