Source-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/arch/evbppc/explora



On Sun, Jan 08, 2006 at 10:02:24PM +0900, Izumi Tsutsui wrote:
> In article <20051231140902.3422E2DA27%cvs.netbsd.org@localhost>
> hannken%NetBSD.org@localhost wrote:
> 
> > Modified Files:
> >     src/sys/arch/evbppc/explora: machdep.c
> > 
> > Log Message:
> > Use our own function to copy traps.  We cannot use memcpy() anymore
> > because the destination may be zero.
> 
> Isn't it better to disable _DIAGASSERT()'s in
> src/common/lib/libc/string/bcopy.c on building libkern?
> arch/powerpc/oea/oea_machdep.c may have the same problem.

>From a quick grep only amigappc, explora, oea and walnut initialize the
reserved trap vector 0x0.  I think it is better to special case one
occurence per machine and have a diagnostic for >99% of the memcpy's.

We could install a powerpc-generic function in powerpc/include/trap.h
useable by all powerpc machines.
-- 
Juergen Hannken-Illjes - hannken%eis.cs.tu-bs.de@localhost - TU Braunschweig 
(Germany)



Home | Main Index | Thread Index | Old Index