Subject: Re: CVS commit: src/sys/dev/scsipi
To: Jaromir Dolecek <jdolecek@NetBSD.org>
From: James Chacon <jmc@NetBSD.org>
List: source-changes
Date: 12/16/2005 11:53:11
On Fri, Dec 16, 2005 at 06:51:11PM +0100, Jaromir Dolecek wrote:
> On Fri, Dec 16, 2005 at 05:33:30PM +0000, Christos Zoulas wrote:
> > In article <87oe3hugp1.fsf@snark.piermont.com>,
> > Perry E. Metzger <perry@piermont.com> wrote:
> > >
> > >Reinoud Zandijk <reinoud@netbsd.org> writes:
> > >> Module Name:	src
> > >> Committed By:	reinoud
> > >> Date:		Thu Dec 15 17:56:32 UTC 2005
> > >>
> > >> Modified Files:
> > >> 	src/sys/dev/scsipi: cd.c
> > >>
> > >> Log Message:
> > >> Clean up cdgetdisklabel. It was jumping over a return...
> > >
> > >Did anyone review this change?
> > 
> > Yes, it is fine.
> 
> Including the new non-optional printf()? Please back that part
> off.

It should probably be ifdef'd by DIAGNOSTIC.

James