--qDbXVdCdHGoSgWSk
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Dec 14, 2005 at 09:42:52PM +0000, David Laight wrote:
> > > > If the rval is SCAN_CONTINUE it now returns a standard error that no
> > > > disklabel was found instead of the NULL.
> > > 
> > > Hummm - that was more or less deliberate, IIRC some of the callers
> > > need a disklabel filled in with partition 'a' and 'd' when there
> > > is nothing found on the disk.

Deliberate??? you leave an obvious bug there deliberately?

> I've reverted it, it breaks the default label for disks that have neither
> MBR nor NetBSD label.
> There may be alternative fixes to retain more of the default label...

Sounds like those places need fixing! The `default label' IS still passed 
back only the resulting string changed.

Without the change its impossible to tell by the caller that a disklabel is 
present or not and thus is impossible to select the default label.

Reinoud


--qDbXVdCdHGoSgWSk
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (NetBSD)

iQEVAwUBQ6CaYYKcNwBDyKpoAQKdvgf/dVXHbvgn1eaPcmdAupD7oJvEw+0zxI3h
8oD1p+FRf6+xg6Gtk4IFk4rsA4BDBE0o8+mXADEP1Iu772X6W7wWa8vWokg2REwi
SumkVuU1P2B8zqhAJZyn/UpuXo0EDX3vZiNyaLa6Z4zDFULXE6avBYJcC4GAibm9
nstNNdyMux0CWC7HMFjg3xPqfhGWAgVluvxu3D88zpwkgKUsYkPHopCGF922xm2k
ICmCKKXyBT4rSC/K9y5HnAHLpfNeA/RRq7KVP9NaJS+LNVI9KUpqxZi4gfqEn5tQ
ANldFWGa/EH16y06Hx2KphrjJPGxOtW06tJ0kOXJIfQxIdeeweWq4A==
=g5j6
-----END PGP SIGNATURE-----

--qDbXVdCdHGoSgWSk--