--CdrF4e02JqNVZeln
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Nov 30, 2005 at 04:51:41PM +0100, Reinoud Zandijk wrote:
> On Wed, Nov 30, 2005 at 03:45:16AM +0000, YAMAMOTO Takashi wrote:
> > Modified Files:
> > 	src/sys/miscfs/genfs: genfs_vnops.c
> >=20
> > Log Message:
> > revert rev.1.111 as it isn't necessary or correct.
> > - currently no one in tree has a problem with zero b_lblkno, afaik.
> > - this buf is used for "devvp", so it doesn't make sense to
> >   use lbn in the "vp".
>=20
> i'll have to disagree. Some filingsystems like ntfs, arla and others that=
=20
> do 1:1 translation in their vop_bmap function DONT pass their "devvp" but=
=20
> their "vp" and thus it makes sense for them. As a compromise we could=20
> adjust the value of b_lblkno the same way as b_blkno is adjusted. In that=
=20
> way it would allways point to the correct lbn whatever scheme or method i=
s=20
> used.

As I understand it, these file systems work fine now. Thus they do NOT=20
NEED such a change.

The only reason I see for this change was that it makes more sense for=20
you. I don't think that's a good reason for this change given that the=20
b_blkno =3D=3D and !=3D b_lblkno cases have different semantic meanings.

Feel free to change b_lblkno as you see fit once you are in your own=20
strategy routine. When you get into your routine, b_lblkno is all yours.

Take care,

Bill

--CdrF4e02JqNVZeln
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (NetBSD)

iD8DBQFDje/CWz+3JHUci9cRAoP1AJ4wqce2kORq9TZPO/xnQ9SdTAqsGACffBEf
E93yqYFPC0TVDN/NNPJwAL0=
=ZqHl
-----END PGP SIGNATURE-----

--CdrF4e02JqNVZeln--