Subject: Re: CVS commit: src/sys/miscfs/genfs
To: YAMAMOTO Takashi <yamt@netbsd.org>
From: Reinoud Zandijk <reinoud@netbsd.org>
List: source-changes
Date: 11/30/2005 16:51:41
--jI8keyz6grp/JLjh
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
On Wed, Nov 30, 2005 at 03:45:16AM +0000, YAMAMOTO Takashi wrote:
> Modified Files:
> src/sys/miscfs/genfs: genfs_vnops.c
>
> Log Message:
> revert rev.1.111 as it isn't necessary or correct.
> - currently no one in tree has a problem with zero b_lblkno, afaik.
> - this buf is used for "devvp", so it doesn't make sense to
> use lbn in the "vp".
i'll have to disagree. Some filingsystems like ntfs, arla and others that
do 1:1 translation in their vop_bmap function DONT pass their "devvp" but
their "vp" and thus it makes sense for them. As a compromise we could
adjust the value of b_lblkno the same way as b_blkno is adjusted. In that
way it would allways point to the correct lbn whatever scheme or method is
used.
Reinoud
--jI8keyz6grp/JLjh
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (NetBSD)
iQEVAwUBQ43KgIKcNwBDyKpoAQJuRgf/flpwiHmDTKEO8nWQW1SPnrmwIdABt9JV
cIZJwgs+hLSY/OlDsH3uPtIHi+0BZWn2rd3te+zKqYJjk6cnFCHF7+Cr10vxTtMU
+CVI4DblFQPDvpDR33tZLYea4FgxWRW1f+HVsIJzkNrZT+W3zgpr2EenzU/0cL+h
VR5X6bAVPCj0aVzo5WPOSkC+Li0gRphtN3FDDZORTDZl5vHGG+lMvUC4DqfBttfi
COLRevfSibaXYzASESOsFtc8IetFbXsBtFBwokJZESl6nyDj9+CAvZTpO6HwUzGJ
gmqCXDhHht0DgXN1ZJ3mSXRPOACQdWMb67YsHyjKOuBoARcCg6qPrg==
=/Ogk
-----END PGP SIGNATURE-----
--jI8keyz6grp/JLjh--