Subject: Re: CVS commit: src/lib/libc/rpc
To: Rui Paulo <rpaulo@fnop.net>
From: Chuck Silvers <chuq@chuq.com>
List: source-changes
Date: 11/07/2005 20:22:46
On Sat, Nov 05, 2005 at 10:26:38PM +0000, Rui Paulo wrote:
> | since there's only 1 file descriptor in this case, it seems better
> | to just go back to the previous pollts() implementation.
>
> The objective here was, as the FreeBSD commit log shows:
>
> Revision 1.15 / (download) - annotate - [select for diffs], Tue Oct 15
> 22:28:59 2002 UTC (3 years ago) by iedowse
> Branch: MAIN
> CVS Tags: RELENG_5_1_BP, RELENG_5_1_0_RELEASE, RELENG_5_1,
> RELENG_5_0_BP, RELENG_5_0_0_RELEASE, RELENG_5_0
> Changes since 1.14: +90 -158 lines
>
> Use kqueue(2) instead of poll(2) to wait for replies and timeouts
> in the UDP RPC client code. As a side-effect, this fixes some bugs
> that might prevent the RPC call from ever timing out for example
> if the server keeps responding with the wrong xid. This could
> probably be simplified further by using the EVFILT_TIMER filter.
we can keep the timeout fixes and just go back to pollts() as the
mechanism for sleeping. do you want to code that up or should I?
-Chuck