Subject: Re: CVS commit: src/sys/compat/linux/common
To: Jaromir Dolecek <jdolecek@NetBSD.org>
From: Rui Paulo <rpaulo@fnop.net>
List: source-changes
Date: 11/06/2005 17:32:37
--OZkY3AIuv2LYvjdk
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 2005.11.06 17:55:33 +0100, Jaromir Dolecek wrote:
| On Sun, Nov 06, 2005 at 03:30:40PM +0000, Emmanuel Dreyfus wrote:
| > On Sun, Nov 06, 2005 at 12:17:10PM +0000, Rui Paulo wrote:
| > > This broke i386 because it does not define LINUX_NPTL but has
| > > linux_sched_{get|set}affinity().
| >=20
| > Oh, yes, that's because Tom just added them to i386 syscall.master
| > in order to restore the build when linux_sched_{get|set}affinity()
| > were not ifdef LINUX_NPTL. I did not noticed it. A build break for a
| > build break :-)
| >=20
| > The simpliest way is probably to back out that change. Tom, is it
| > okay for you?
|=20
| Err, if linux_sched_{get|set}affinity() doesn't require other
| LINUX_NPTL code, it should rather be added to all ports, shouldn't
| it?

I suppose that you only want linux_sched_{get|set}affinity() when you
want LINUX_NTPL to be defined. The problem is that there is no way to
dinamicaly define entries under syscalls.master based on pre-processor
directives.

		-- Rui Paulo

--OZkY3AIuv2LYvjdk
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (NetBSD)

iD8DBQFDbj41ZPqyxs9FH4QRAvtVAJ4mTesjrQx1T3jJX6aqQKAI0FVEaACeIdDf
xL5pgXPuylnhQoRSbTDm1ek=
=JGEu
-----END PGP SIGNATURE-----

--OZkY3AIuv2LYvjdk--