Re: CVS commit: src/sys/arch

[Simon Burge <simonb%wasabisystems.com@localhost>]

Izumi Tsutsui wrote:

> In article <20051105134332.56FDC23572%thoreau.thistledown.com.au@localhost>
> simonb%wasabisystems.com@localhost wrote:
> 
> > mips/wired_map.c is only added to the source list if the
> > ENABLE_MIPS3_WIRED_MAP option is enabled - it's not automatically
> > included.
> 
> Yes, I know, but any user could specify options ENABLE_MIPS3_WIRED_MAP
> in his config file and it would cause an error. I thought we had to
> move definition of mips/wired_map.c to MD files.* or to have
> MD <machine/wired_map.h> on all ports to prevent it.

I suspect anyone enabling ENABLE_MIPS3_WIRED_MAP will know the
ramifications of doing that, and if they get an error they'll
know what to do :-)

I think we either want a wired_map(9), or at least a few
comments in mips/wired_map.c saying what is expected to exist
in <machine/wired_map.h>.  I'm also not 100% sure if we should
provide defaults for MIPS3_NWIRED_ENTRY (should that be called
MIPS3_NWIRED_ENTRIES?) and MIPS3_WIRED_SIZE in <mips/wired_map.h>
or whether we specify that these constants have to be defined
in <machine/wired_map.h>.

Garrett - your thoughts on that?

> But yes, maybe just I'm a paranoia 8-) and I don't have objection
> to remove them if you want.

I think it's cleaner to only have them if they're used, similar to say
<machine/pci_machdep.h> which only exists for some MIPS ports.  I'll
remove them (but not tonight - too late already!).

Simon.
--
Simon Burge                            <simonb%wasabisystems.com@localhost>
NetBSD Support and Service:         http://www.wasabisystems.com/