On Mon, Oct 24, 2005 at 02:36:26PM +0900, YAMAMOTO Takashi wrote: > > Module Name: src > > Committed By: wrstuden > > Date: Thu Sep 8 22:51:36 UTC 2005 > > > > Modified Files: > > src/share/man/man9: buffercache.9 > > > > Log Message: > > Note the fact that buffer cache takes block numbers in > > units of DEV_BSIZE, even if the device's device size is > > larger. Update date. > > it's plainly wrong. How is it plainly wrong? sdstrategy() does DEV_BSIZE -> lp->d_secsize conversion, as does cdstrategy(). wdstrategy() does the same. Thus the block number had to have been in units of DEV_BSIZE to begin with. I am very confused. As all the code I looked at actually works the way I describe in the change, I fail to see how it is "plainly wrong." Confusing, yes! Non-intuitive, yes! But that's what the code is doing now. > besides, i doubt if it's appropriate to document > specfs-specific things in this manpage. What units are bread()'s blkno in? Turns out they are NOT in the units of blocks on the device. Thus documentation with bread() and bwrite(). This documentation also is the direct result of one of my SoC projects stalling for about a week as the student assumed bno was in device blocks, and then nothing worked. When he switched it to DEV_BSIZE blocks, things started working. I strongly believe that we need enough documentation so that someone looking at this man page can figure out what units to use for blkno for bread() and bwrite(). The belief above would be satisfied with a cross-reference to another man page that went into this (assuming it was clear that you REALLY NEEDED to look at the other page). However the units used for block numbers in the buffer cache really seems to me to be appropriate for "man 9 buffercache". This behavior doesn't seem to me to be at all specfs-specific, so it seems fine to document it here; what specfs-level code does is also what buffer cache code has to work with. Take care, Bill
Attachment:
pgpW7kVGmuPum.pgp
Description: PGP signature