Subject: Re: CVS commit: src/sys/dev/ic
To: Izumi Tsutsui <tsutsui@netbsd.org>
From: David Laight <david@l8s.co.uk>
List: source-changes
Date: 09/10/2005 20:54:39
On Sat, Sep 10, 2005 at 07:15:44PM +0000, Izumi Tsutsui wrote:

> Whele here, change style of some byteswap ops from
> 	foo = bar();
> 	foo = ahc_htole32(foo);
> to
> 	foo = ahc_htole32(bar());

That is likely to break the code.
The underlying htole32() code could easily be a #define that
evalautes its argument more than once.

	David

-- 
David Laight: david@l8s.co.uk