Subject: Re: CVS commit: src/bin/systrace
To: Elad Efrat <elad@netbsd.org>
From: Niels Provos <provos@citi.umich.edu>
List: source-changes
Date: 08/10/2005 15:41:19
Hi Elad,

it seems that this commit breaks the purpose of the inpath filter.

inpath is supposed to match the behavior of somebody doing "cd
..". So, if you start at pwd = /usr/home/elad

then inpath "/usr/home/elad" matches

  cd "/usr/home/elad"
  cd "/usr/home"
  cd "/usr"
  cd "/"

Please, revert your commit.

Niels.

On Fri, Jul 01, 2005 at 05:12:41PM +0000, Elad Efrat wrote:
> 
> Module Name:	src
> Committed By:	elad
> Date:		Fri Jul  1 17:12:41 UTC 2005
> 
> Modified Files:
> 	src/bin/systrace: filter.c
> 
> Log Message:
> Make `inpath' work as expected. Closes PR 29677.
> 
> Reported by Christian Biere, based on usenet post by John Wong.
> 
> 
> To generate a diff of this commit:
> cvs rdiff -r1.27 -r1.28 src/bin/systrace/filter.c
> 
> Please note that diffs are not public domain; they are subject to the
> copyright notices on the relevant files.