Source-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/arch/i386/stand/pxeboot



On Wed, 15 Jun 2005, Bang Jun-Young wrote:

I agree S_SIZE() is ugly, but MEMSTRCMP() is not that good, either.
There are two (better) solutions for this:

1. Just s/bcmp/memcmp/.

-                       if (bcmp(pxenv->Signature, S_SIZE("PXENV+")))
+                       if (memcmp(pxenv->Signature, S_SIZE("PXENV+")))

The man page shows memcmp to take three arguments (like bcmp). This is
one reason I had such trouble trying to fix this myself.

--
Hisashi T Fujinaka - htodd%twofifty.com@localhost
BSEE(6/86) + BSChem(3/95) + BAEnglish(8/95) + MSCS(8/03) + $2.50 = latte



Home | Main Index | Thread Index | Old Index