Re: CVS commit: src/sys

[David Young <dyoung%pobox.com@localhost>]

On Thu, Jun 09, 2005 at 02:19:59AM +0000, Andrew Brown wrote:
> 
> Module Name:  src
> Committed By: atatat
> Date:         Thu Jun  9 02:19:59 UTC 2005
> 
> Modified Files:
>       src/sys/kern: init_sysctl.c kern_sysctl.c uipc_domain.c vfs_bio.c
>       src/sys/net: rtsock.c
>       src/sys/net80211: ieee80211.c
>       src/sys/netinet: ip_input.c tcp_usrreq.c
>       src/sys/nfs: nfs_vfsops.c
>       src/sys/sys: sysctl.h
>       src/sys/ufs/lfs: lfs_vfsops.c
> 
> Log Message:
> Properly fix the constipated lossage wrt -Wcast-qual and the sysctl
> code.  I know it's not the prettiest code, but it seems to work rather
> well in spite of itself.

Andrew,

It seems like the const sysctlnodes are const for a reason;
sysctl_lookup's argument is likewise non-const for a reason.  So why is
it ever correct to pass an __UNCONST'd const sysctlnode to sysctl_lookup?
This will not conceal bugs?

Dave

> 
> 
> To generate a diff of this commit:
> cvs rdiff -r1.42 -r1.43 src/sys/kern/init_sysctl.c
> cvs rdiff -r1.181 -r1.182 src/sys/kern/kern_sysctl.c
> cvs rdiff -r1.51 -r1.52 src/sys/kern/uipc_domain.c
> cvs rdiff -r1.145 -r1.146 src/sys/kern/vfs_bio.c
> cvs rdiff -r1.76 -r1.77 src/sys/net/rtsock.c
> cvs rdiff -r1.34 -r1.35 src/sys/net80211/ieee80211.c
> cvs rdiff -r1.216 -r1.217 src/sys/netinet/ip_input.c
> cvs rdiff -r1.104 -r1.105 src/sys/netinet/tcp_usrreq.c
> cvs rdiff -r1.147 -r1.148 src/sys/nfs/nfs_vfsops.c
> cvs rdiff -r1.135 -r1.136 src/sys/sys/sysctl.h
> cvs rdiff -r1.181 -r1.182 src/sys/ufs/lfs/lfs_vfsops.c
> 
> Please note that diffs are not public domain; they are subject to the
> copyright notices on the relevant files.

-- 
David Young             OJC Technologies
dyoung%ojctech.com@localhost      Urbana, IL * (217) 278-3933