--GfGY513Dtlyb3WpA
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Jun 05, 2005 at 01:00:13PM +1000, matthew green wrote:
  |=20
  |   =20
  |    Module Name:	src
  |    Committed By:	lukem
  |    Date:		Sun Jun  5 01:15:29 UTC 2005
  |   =20
  |    Modified Files:
  |    	src/lib/libc/gen: getpwent.c
  |   =20
  |    Log Message:
  |    Cosmetic tweak previous; IMHO we don't need the XXX comment in this
  |    case, since I prefer to NULL initialize variables in this situation.
  |=20
  | why not?  it seems superfluous and GCC is wrong.

For code I've been maintaining (including getpwent.c), that's the
way I prefer to do it.  It helps identify obvious mistakes when
adding extra code blocks or debug messages; if you get a "(null)"
message printed it's fairly obvious that you haven't initialized
it when you should, as opposed to just getting random garbage
displayed.

--GfGY513Dtlyb3WpA
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (NetBSD)

iD8DBQFCoptmpBhtmn8zJHIRAsDnAKCPU5AJ2Vye9FgoTmO1pOYGUSpxDQCfSwgT
7gwBeA07sqnJ2t0ZZVgk0oQ=
=jqjl
-----END PGP SIGNATURE-----

--GfGY513Dtlyb3WpA--