On Mon, May 02, 2005 at 01:52:52AM +0900, Izumi Tsutsui wrote: > In article <20050501162107.DB86D2DA27%cvs.netbsd.org@localhost> > riz%netbsd.org@localhost wrote: > > > Modified Files: > > src/gnu/dist/gettext/gettext-tools/src: po-lex.c > > > > Log Message: > > Only test if a char is >= 0x00 when CHAR_MIN is < 0, so gcc doesn't > > warn about the comparison always being true. Fixes build for macppc > > target. > > Isn't it better to test ((mbc->buf[0] & 0x80) == 0) for readability > if it checks control characters? Possibly - to be frank, I'm almost completely unfamiliar with gettext, and since this is externally-maintained src, I addressed the issue in the same way it had been addressed elsewhere in the file. (Apparently, they missed one) I certainly wouldn't object if someone else wanted to fix it "better". +j
Attachment:
pgpmlPX3Wzw9n.pgp
Description: PGP signature