Subject: Re: CVS commit: src/lib/libpam/modules
To: Jason Thorpe <thorpej@shagadelic.org>
From: Matt Thomas <matt@3am-software.com>
List: source-changes
Date: 04/25/2005 09:01:48
Jason Thorpe wrote:
>
> On Apr 25, 2005, at 8:43 AM, Matt Thomas wrote:
>
>>
>> Module Name: src
>> Committed By: matt
>> Date: Mon Apr 25 15:43:34 UTC 2005
>>
>> Modified Files:
>> src/lib/libpam/modules/pam_krb5: Makefile
>> src/lib/libpam/modules/pam_ksu: Makefile
>>
>> Log Message:
>> Add ${DESTDIR}/usr/include/krb5 to CPPFLAGS so <parse_units.h> can be
>> found.
>
>
> This is wrong. The <parse_units.h> reference should be <krb5/
> parse_units.h> instead. It's just plain broken to require -I/usr/
> include/krb5 when including <krb5/krb5.h> ... those headers should do
> the right thing all on their own.
Except that gen.c already has code for including <parse_units.h> without
the krb5/. It didn't seem right to have krb5/ in one place and not the
other. And since this is crypto/dist I made the non-NetBSD specific
change.
--
Matt Thomas email: matt@3am-software.com
3am Software Foundry www: http://3am-software.com/bio/matt/
Cupertino, CA disclaimer: I avow all knowledge of this message.