Subject: Re: CVS commit: src/sys/dev
To: Jason Thorpe <thorpej@shagadelic.org>
From: Perry E. Metzger <perry@piermont.com>
List: source-changes
Date: 02/27/2005 00:24:16
Jason Thorpe <thorpej@shagadelic.org> writes:
>> While this is all fine and wonderful, you have now made it a LOT
>> more difficult to e.g. diff drivers that we share with other OSs.
>
> Oh yah, and you've made it that much easier for those who are going to
> merge ktrace-lwp and yamt-km, too.  I'm sure they really appreciate
> that.
>
> This kind of gratuitous change really irks me, especially so close to
> wanting to branch 3.0.

I discussed it with Christos and Matt Thomas briefly, and neither
objected.

On the ktrace-lwp thing, I held off doing such stuff for several weeks
on the basis that he was "just about to commit".

On the 3.0 thing, the reason I'm doing whitespace and not __P is
because whitespace is much safer -- you can actually screw stuff up
with de-__Ping. However, removing trailing whitespace is very low
risk. I'll resume ANSIfication etc. after the branch happens.

Perry