Subject: Re: CVS commit: src
To: Jason Thorpe <thorpej@shagadelic.org>
From: Emmanuel Dreyfus <manu@netbsd.org>
List: source-changes
Date: 02/24/2005 19:13:46
Jason Thorpe <thorpej@shagadelic.org> wrote:

> >> Perhaps we should provide SADB_X_EALG_AESCBC in our pfkey headers as
> >> well?
> >
> > I thought about it but I fear we could break software doing this:
> >
> >         switch(foo) {
> > #ifdef SADB_X_EALG_AESCBC
> >         case SADB_X_EALG_AESCBC:
> >                 /* whatever */
> > #endif
> > #ifdef SADB_X_EALG_AES
> >         case SADB_X_EALG_AES:
> >                 /* whatever */
> > #endif
> >         }
>=20
> Ok, then perhaps we should simply change the name of our constant to=20
> the AESCBC flavor.  It is certainly more descriptive.

That will break source compatibility with programs using
SADB_X_EALG_AES. But I may be a bit too conservative.=20

--=20
Emmanuel Dreyfus
Un bouquin en fran=E7ais sur BSD:
http://www.eyrolles.com/Informatique/Livre/9782212114638/livre-bsd.php
manu@netbsd.org