Subject: Re: CVS commit: src
To: Emmanuel Dreyfus <manu@netbsd.org>
From: Jason Thorpe <thorpej@shagadelic.org>
List: source-changes
Date: 02/24/2005 09:11:47
On Feb 24, 2005, at 8:43 AM, Emmanuel Dreyfus wrote:

> Jason Thorpe <thorpej@shagadelic.org> wrote:
>
>> Perhaps we should provide SADB_X_EALG_AESCBC in our pfkey headers as
>> well?
>
> I thought about it but I fear we could break software doing this:
>
>         switch(foo) {
> #ifdef SADB_X_EALG_AESCBC
>         case SADB_X_EALG_AESCBC:
>                 /* whatever */
> #endif
> #ifdef SADB_X_EALG_AES
>         case SADB_X_EALG_AES:
>                 /* whatever */
> #endif
>         }

Ok, then perhaps we should simply change the name of our constant to 
the AESCBC flavor.  It is certainly more descriptive.

-- thorpej