--gKMricLos+KVdGMg
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Feb 10, 2005 at 10:22:32PM +0000, David Laight wrote:
>=20
> Module Name:	src
> Committed By:	dsl
> Date:		Thu Feb 10 22:22:32 UTC 2005
>=20
> Added Files:
> 	src/sys/ufs/ffs: ffs_snapshot_stub.c
>=20
> Log Message:
> Add a stub file so that snapshot support can be compiled out.
> Will allow INSTALL_TINY to fit back in its designated space.

This part sounds good.

> Since the calling code doesn't allow a snapshot mount to fail, this code
> will output a warning and delete any snapshots it finds.
> This only happend on rw mounts - snapshots don't seem to be created
> when mounting ro.

This point seems very wrong. If I understand you, with your INSTALL_TINY=20
hack, if someone tries to mount a snapshot, all snapshots on the disk will=
=20
be destroyed. That strikes me as VERY dangerous, assuming I understand the=
=20
issues right.

If I'm misunderstanding, please let me know. :-)

> The whole way the snapshots gets mounted is a PITA anyway, the superblock
> 'last mounted' time should be used to validate that the fs hasn't been
> mounted elsewhere.

Sounds reasonable.

Take care,

Bill

--gKMricLos+KVdGMg
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (NetBSD)

iD8DBQFCC/rmWz+3JHUci9cRAqvTAJ963hOS4swNgRMoqClFdkiC8tIs3gCggXdx
SC26UVfKjCnBoExCBSuYTz4=
=5hI9
-----END PGP SIGNATURE-----

--gKMricLos+KVdGMg--