Subject: Re: CVS commit: src/sys/net
To: matthew green <mrg@eterna.com.au>
From: Reinoud Zandijk <reinoud@netbsd.org>
List: source-changes
Date: 12/30/2004 14:31:55
--fdj2RfSjLxBAspz7
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Hiya Matthew,

On Thu, Dec 30, 2004 at 11:38:57PM +1100, matthew green wrote:
> this change seems broken to me.  the #if you removed encompasses
> exactly how the label is used, and as you say, it now will fail
> without options INET.  what is the purpose of this change?  i
> think it should be reverted.

The change is :

@@ -732,9 +732,7 @@
        default:
                /* printf("token_input: unknown dsap 0x%x\n", l->llc_dsap); */
                ifp->if_noproto++;
-#if defined(INET) || defined(NS) || defined(DECNET)
        dropanyway:
-#endif
                m_freem(m);
                return;
        }
-----

In the same function (on line 790) there is the `catch-all' line that jumps 
to that label; if INET is not defined the label won't be defined without 
the patch!

                default:
                        /*
                        printf("token_input: unknown protocol 0x%x\n", etype);
                        */
                        ifp->if_noproto++;
                        goto dropanyway;
                }


Hope this helps...

Cheers,
Reinoud

--fdj2RfSjLxBAspz7
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (NetBSD)

iQEVAwUBQdQDQ4KcNwBDyKpoAQKwRAgAv66C9bIuxNttV8mT9wtu4jQpwwvi9y1A
fceQb2Wfk3Iz6p39y5eNGqJoYYbTK8FYiqTWkWoKYtqj7Ac/RAA76HOITtaD/k7x
qXa+KqEvdiNWjGqQt3pnPloIGlfv4baYbX3TAKYuxgDz8AKl2aREPa5MhVBiYbai
L88xCyJVY407EiJxsAmRxgzTYCBCrFMhKclAVahL2OilL8s4YDpbmQTl3HU29fux
ehgzj2iYa27BX20pkcsm/UCpGw55aMLT8WAFQ6422ewzu4q0vk7Ap0FMoiT9xMU4
04S+9ve347NKT1X6NOlATR6nmnEAob0AJFx+NargwKU1ZYRt2/M2GQ==
=CY8V
-----END PGP SIGNATURE-----

--fdj2RfSjLxBAspz7--