Subject: Re: CVS commit: src/sys/arch/macppc
To: Michael Wolfson <mbw@netbsd.org>
From: Bill Studenmund <wrstuden@netbsd.org>
List: source-changes
Date: 11/08/2004 09:09:35
--3V7upXqbjpZ4EhLz
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Nov 07, 2004 at 04:24:34AM +0000, Michael Wolfson wrote:
>=20
> Module Name:	src
> Committed By:	mbw
> Date:		Sun Nov  7 04:24:34 UTC 2004
>=20
> Modified Files:
> 	src/sys/arch/macppc/include: disklabel.h
> 	src/sys/arch/macppc/macppc: disksubr.c
>=20
> Log Message:
> Add disklabel recognition for  another Apple file type
> "BZB_ROOTFS_NEW        0xc000"

That value needs to be reverted. You've broken disklabel handling - what=20
used to be a "usr" partition will now be a "root" partition.

BZB_ROOTFS_NEW is the OR of BZB_ROOTFS and BZB_USRFS, thus it can't=20
possibly work right given the logic in disksubr.c. Also, anything that=20
actually had a flag value of "BZB_ROOTFS_NEW" would have passed the=20
previous test.

Please revert these changes.

Take care,

Bill

--3V7upXqbjpZ4EhLz
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (NetBSD)

iD8DBQFBj6hPWz+3JHUci9cRAqgKAJ930fcGR1YJqZW0x5+gGripi+pcNQCfcwnd
Rud+KTfR0s9HCQEy0tXNwW8=
=OWQV
-----END PGP SIGNATURE-----

--3V7upXqbjpZ4EhLz--