Subject: Re: CVS commit: src/dist/ntp/ntpd
To: matthew green <mrg@eterna.com.au>
From: Perry E. Metzger <perry@piermont.com>
List: source-changes
Date: 10/31/2004 14:21:57
matthew green <mrg@eterna.com.au> writes:
>    You've made several changes in dist/ directories, including to this
>    and to dhcp.
>    
>    These are externally maintained codebases. I'm not sure it is
>    reasonable to be changing them this way unless you intend to make sure
>    that the patches are accepted upstream.
>
>
> these changes are needed for compiler warnings to be fixed.  there's
> been at least a few bugs fixed in the process as well...
>
> once all these are done, dsl will backout a bogus change that i made
> to ctype.h in 1998....

Sure, but another way to do this is to turn off warnings for the third
party software until we can get the upstreams to accept patches.

Perry